better documentation for maximal_binary_length_from_base64 #871
+57
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldreik
reviewed
Dec 4, 2025
Member
Author
|
@erikcorry what do you think? |
anonrig
approved these changes
Dec 6, 2025
Collaborator
|
looks good! |
pauldreik
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@erikcorry recently remarked that the
maximal_binary_length_from_base64could be confusing. This PR attempts to better document it and justify how it works.The contract is thus:
The reason why it is reasonable is that most base64 inputs have very few ignorable characters. And if you add lots and lots of spaces to your base64 payloads, you are probably not focused on minimizing memory usage.