Skip to content

illustrate issue in issue 864 [NOT FOR MERGING] #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lemire wants to merge 6 commits into from
Closed

illustrate issue in issue 864 [NOT FOR MERGING] #869

lemire wants to merge 6 commits into from
+339 −344

Conversation

@lemire
Copy link
Member

@lemire lemire commented Dec 4, 2025

@pauldreik in #864 (comment)_ inquire as to why it was useful to remove an anonymous namespace.

This PR aimes to illustrate the issue.

@lemire lemire mentioned this pull request Dec 4, 2025
Merged
@pauldreik
Copy link
Collaborator

pauldreik commented Dec 4, 2025

ah! for the record, this is the compilation error:

/home/pauldreik/code/delaktig/simdutf/src/implementation.cpp: In function ‘size_t simdutf::convert_utf16_to_utf8_safe(const char16_t*, size_t, char*, size_t)’:
/home/pauldreik/code/delaktig/simdutf/src/implementation.cpp:1793:26: error: ‘high_surrogate’ is not a member of ‘simdutf::scalar::utf16’; did you mean ‘simdutf::scalar::{anonymous}::utf16::high_surrogate’?
 1793 |       if (scalar::utf16::high_surrogate(buf[read_len - 1])) {
      |                          ^~~~~~~~~~~~~~
compilation terminated due to -Wfatal-errors.

@lemire
Copy link
Member Author

lemire commented Dec 4, 2025

@pauldreik

ah! for the record, this is the compilation error:

And for the record, I don't really understand the error. I can sort of make up a story in my mind, but I couldn't get myself to explore the topic.

@lemire
Copy link
Member Author

lemire commented Dec 4, 2025

@pauldreik Now that I disclosed that I don't know why it fails, the answer becomes obvious to me.

So, yeah, I think it is obvious why it does so. I just needed coffee.

@lemire lemire marked this pull request as draft December 4, 2025 15:18
@lemire lemire closed this Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lemire @pauldreik @anonrig