support reproducibility for debug sources #848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While option --debug-sources is used, the generated source file contains build path comments which caused the build is not reproducible [1] ...subprojects/simdutf/simdutf.h... 1 /* auto-generated on 2025-03-17 16:13:41 -0400. Do not edit! */ 2 /* begin file include/simdutf.h */ 3 // /build-dir/vte-0.82.1/subprojects/simdutf/include/simdutf.h:1 4 #ifndef SIMDUTF_H ...subprojects/simdutf/simdutf.h... After apply this commit, use relative path to instead ...subprojects/simdutf/simdutf.h... 1 /* auto-generated on 2025-03-17 16:13:41 -0400. Do not edit! */ 2 /* begin file include/simdutf.h */ 3 // include/simdutf.h:1 4 #ifndef SIMDUTF_H ...subprojects/simdutf/simdutf.h... [1] https://reproducible-builds.org/ Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
Collaborator
|
I was not able to reproduce the reported problem. Can you please share exactly how you invoke the amalgamation? |
Member
|
@pauldreik I think he means that the comments will include full path and not relative paths, thus making the file sensitive to where the script was run ??? That's what I assumed. The PR itself does not seem problematic... it only affects the comments generated. |
Collaborator
|
I figured out how to invoke it to demonstrate the problematic behaviour, one had to enable a feature to see it: singleheader/amalgamate.py --debug-sources --with-utf16with that, I can confirm the patch is good. Thanks! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While option --debug-sources is used, the generated source file contains build path comments which caused the build is not reproducible [1]
...subprojects/simdutf/simdutf.h...
1 /* auto-generated on 2025-03-17 16:13:41 -0400. Do not edit! /
2 / begin file include/simdutf.h */
3 // /build-dir/vte-0.82.1/subprojects/simdutf/include/simdutf.h:1
4 #ifndef SIMDUTF_H
...subprojects/simdutf/simdutf.h...
After apply this commit, use relative path to instead
...subprojects/simdutf/simdutf.h...
1 /* auto-generated on 2025-03-17 16:13:41 -0400. Do not edit! /
2 / begin file include/simdutf.h */
3 // include/simdutf.h:1
4 #ifndef SIMDUTF_H
...subprojects/simdutf/simdutf.h...
[1] https://reproducible-builds.org/