Skip to content

Conversation

@ronag
Copy link
Collaborator

@ronag ronag commented Aug 29, 2024

Adds a "safe" version of convert_latin1_to_utf8 with a maximum output length.

Refs: nodejs/node#54526

@ronag ronag force-pushed the convert_latin1_to_utf8_s branch 12 times, most recently from adcfaf7 to 4e1eb4b Compare August 29, 2024 11:32
@ronag
Copy link
Collaborator Author

ronag commented Aug 29, 2024

Not sure what else I have to do to make this pass CI... a little help?

@lemire
Copy link
Member

lemire commented Aug 29, 2024

I will check next week. :-) (Currently away from my desk.)

@ronag ronag force-pushed the convert_latin1_to_utf8_s branch 10 times, most recently from 399649f to ade5fc0 Compare August 31, 2024 09:11
Adds a "safe" version of convert_latin1_to_utf8 with a maximum output length.

Refs: nodejs/node#54526
@ronag ronag force-pushed the convert_latin1_to_utf8_s branch from ade5fc0 to eff6b01 Compare August 31, 2024 09:11
@lemire
Copy link
Member

lemire commented Sep 3, 2024

@ronag Please see #556 which is an alternative design.

Note that if we merge #556, I will make sure that it is credited to you (e.g., in the release notes).

@ronag ronag closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants