Merged
Conversation
FranciscoThiesen
approved these changes
Jan 30, 2026
p2996/README.md
Outdated
| CXX=clang++ cmake -B buildreflect -D SIMDJSON_STATIC_REFLECTION=ON -DSIMDJSON_DEVELOPER_MODE=ON | ||
| ``` | ||
| This only needs to be done once. To build the Rust code, add `-D SIMDJSON_USE_RUST=ON`. | ||
| This only needs to be done once. To build the Rust code, add `-D SIMDJSON_USE_RUST=ON`. Note that you should have Rust on your system as a prerequiste for this option to be meaningful. |
Member
Author
|
Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our main branch, the C++26 reflection benchmarks were outdated (and wrong). This PR merges the changes @FranciscoThiesen's separate branch (francisco/ablation_study) with a few additional fixes:
benchmark/static_reflect/citm_catalog_benchmark/rapidjson_citm_catalog_data.hdid not build and appeared to be out of sync. Basically, some values have been optionals, and the code did not reflect that.simdjson::builder::to_jsonfunction returned a simdjson_error (which is an exception) instead of asimdjson::error_code(which is just a number, essentially). This was a bug in the main library (although unlikely to affect anyone at this time since it is not a documented function). Of course, I caught this because because I added checks for the return values (the error).p2996/README.mdso that it is clearer.I note that Nlohmann parsing is disabled for the twitter dataset.
Note that @FranciscoThiesen's branch is not quite in sync as far as the main library is concerned, so there are some differences, possibly.