Conversation
jkeiser
reviewed
Jan 17, 2026
jkeiser
approved these changes
Jan 17, 2026
Member
jkeiser
left a comment
There was a problem hiding this comment.
Been a bit, but this looks good. Love supporting more and more standards!
Member
|
Then again, there are windows failures! So many platforms |
Member
Author
|
@jkeiser I am adding more safety rails to the iterators. So that people cannot so easily misuse the iterators. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should be able to advance easily through the array iterators.
The object iterators should probably never be used directly, they are meant to be used in a for-loop in their current form (they are not general purpose).
I am also putting back the development checks on the debug builds. We accidentally disable them by switching the debug compilation flag to
-Ogwhich is fine, but it is no longer detected as a debug flag.Fixes #2579