moving the builder files in their own directory#2578
Merged
Conversation
Contributor
|
I think this PR broke capability to directtly Here is the compiler error I receive: @lemire is this error related? I am updating from 4.2.4 to 4.3.0 |
Member
Author
|
@georgthegreat Our public header is I am surprised that |
Contributor
|
Ok, I will fix our code. |
Member
Author
|
@georgthegreat We could add such a feature (selective compilation) but I would prefer to do it with feature macros (i.e., we only use X and Y and not Z). |
Contributor
|
It would be nice to have an issue flagged for tracking purposes. |
Member
Author
|
@georgthegreat See #2615 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had the rather unpleasant design where the builder API was mixed up with the ondemand files. This PR splits them up, for more clarity.
Once this is merged, we'll be able to move the SIMD accelerated part (the string escaping) in the various kernel directories which will also be significantly cleaner and scalable.