Skip to content

string_builder range-based append fix#2544

Merged
lemire merged 2 commits intosimdjson:masterfrom
mrizaln:string_builder_ranges_fix
Nov 11, 2025
Merged

string_builder range-based append fix#2544
lemire merged 2 commits intosimdjson:masterfrom
mrizaln:string_builder_ranges_fix

Conversation

@mrizaln
Copy link
Contributor

@mrizaln mrizaln commented Nov 11, 2025

Fixes #2543

Type of change

  • Bug fix
  • New feature
  • Refactor / cleanup
  • Documentation / tests
  • Other (please describe):

Checklist before submitting

  • I added/updated tests covering my change (if applicable)
  • Code builds locally and passes my check
  • Documentation / README updated if needed
  • Commits are atomic and messages are clear
  • I linked the related issue (if applicable)

@mrizaln mrizaln changed the title String builder ranges fix string_builder range-based append fix Nov 11, 2025
Copy link
Member

@lemire lemire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let us wait for the tests to go green.

@lemire lemire merged commit 19549c6 into simdjson:master Nov 11, 2025
83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use of non-existent member type on range-based append on string_builder

2 participants