add: windows wstring support for padded_str#2537
Conversation
|
Internally, we pass the filename string to |
|
Instead of converting to UTF8, which might not work well, I recommend you replace the call to Have a look at simdjson/include/simdjson/padded_string-inl.h Line 134 in 235dbc5 You could just copy paste this old code, and replace fopen by _wfopen. |
i was thinking of this approach but was not sure if it was the right way. |
|
Looks good to me. @Nelson-numerical-software could you review since you created the issue? |
Thanks for this works ! It is good for me too |
Description
padded_string::load()only acceptsstd::string_viewwhich is limiting on windows where file paths with unicode characters require wide strings.padded_string::load(std::wstring_view)overload for Windows (works for C++ version >= 17)Type of change