Skip to content

add missing OUT_OF_CAPACITY error code to error codes array#2527

Merged
lemire merged 2 commits intosimdjson:masterfrom
kevyang:kevyang/fix_dll_import_export
Oct 23, 2025
Merged

add missing OUT_OF_CAPACITY error code to error codes array#2527
lemire merged 2 commits intosimdjson:masterfrom
kevyang:kevyang/fix_dll_import_export

Conversation

@kevyang
Copy link
Contributor

@kevyang kevyang commented Oct 22, 2025

Short title (summary):

Description
OUT_OF_CAPACITY was added as a new error type, but it is missing from the error_codes array. this change adds the missing entry.

Type of change

  • Bug fix

@kevyang
Copy link
Contributor Author

kevyang commented Oct 22, 2025

This new error type was added here: https://github.com/simdjson/simdjson/blob/master/include/simdjson/error.h#L52
However, it is missing from the errors array. My usecase ran into this bug when this triggered a buffer overflow on the array due to the mismatch.

@lemire
Copy link
Member

lemire commented Oct 22, 2025

Looks like a good fix.

Let us run the tests.

@lemire lemire merged commit 49b8672 into simdjson:master Oct 23, 2025
83 checks passed
@lemire
Copy link
Member

lemire commented Oct 23, 2025

This will be part of the text release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants