Francisco/using iterators for containers#2470
Merged
Conversation
…s work with a broader range of containers.
the-moisrex
reviewed
Sep 25, 2025
Member
|
cc @mattgodbolt |
Member
|
Following @the-moisrex's comment, @FranciscoThiesen, could we go with... template <typename T>
concept container_but_not_string =
std::ranges::input_range<T> && !std::is_same_v<T, std::string> &&
!std::is_same_v<T, std::string_view> && !std::is_same_v<T, const char *>; |
lemire
approved these changes
Sep 25, 2025
Member
lemire
left a comment
There was a problem hiding this comment.
This is clearly better code. :-)
Member
|
We shall merge when the tests go green. |
Member
|
This will be in the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented Matt Godbolt's suggestion of using iterators on the concept that matches generic containers. It is broader then depending on the subscript operator + size, so we gain std::list for free... (and a few other containers)
#2459