Conversation
FranciscoThiesen
approved these changes
Sep 2, 2025
Member
FranciscoThiesen
left a comment
There was a problem hiding this comment.
Looks good to me, thank you so much for removing the ugly expand syntax in favor of template for. It was really ugly to look at.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopting the syntax...
Also moving
consteval_to_quoted_escapedto its own file so that we can use it elsewhere (i.e. for enums) and thus make these functions slightly faster.Note that we do not need to escape C++ identifiers, but we want to 'quote' them so that we don't need to mess around with quote charaters.
People like @FranciscoThiesen will understand.