Fix linker errors for downstream users caused by non-inline symbols in header#2403
Merged
lemire merged 1 commit intosimdjson:masterfrom Jul 28, 2025
Merged
Fix linker errors for downstream users caused by non-inline symbols in header#2403lemire merged 1 commit intosimdjson:masterfrom
lemire merged 1 commit intosimdjson:masterfrom
Conversation
Member
|
Good catch. Note that this code hasn’t been released yet! |
Contributor
Author
|
Admittedly a 2 second fix, but I figured this was the quickest way to pinpoint the issue for maintainers. It looks like the actual breaking commit was made a couple weeks ago, so surprising that no one made an issue for it earlier. Maybe most people are tracking a specific release. I track head of master in at least one project, so I'll be sure to report any future breakages should they arise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses non-inlined symbols leaking into public headers after a recent update. Adding an inline specifier to these symbols fixes linker errors for downstream users.
Fixes #2402