JSON builder optimizations#2363
Merged
FranciscoThiesen merged 3 commits intojson_builder_initfrom Apr 14, 2025
Merged
Conversation
Member
|
These are the results I got on my machine with your changes, pretty significant! Before: After: |
Member
|
What a beautiful PR. Would never have guessed the look-up tables could be faster than such a tiny number of comparisons.. The results I got on my machine in terms of total time are even more significant than the ones you reported... 2.1GB/s -> 3.0GB/s. |
Member
|
Really nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These a tiny optimizations on top of
json_builder_init. On one system and one benchmark, it reduces the number of instructions by about 7% and it improves the speed by about 5%.Before:
After: