Json builder init citm bench#2351
Merged
FranciscoThiesen merged 13 commits intojson_builder_initfrom Mar 27, 2025
Merged
Conversation
Member
FranciscoThiesen
commented
Mar 19, 2025
- Adding benchmark for citm_catalog data. (not working for rust yet)
- In the process I've identified that serialization is not supporting std::map<K, V> yet. I can work on that later, might create an issue to track it.
get latest lemire changes.
Member
|
@FranciscoThiesen Please rebase on json_builder_init. We now have std::map support. |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new benchmark for the citm_catalog data along with supporting changes for serialization and deserialization, and also includes minor documentation fixes.
- Adds CitmCatalog benchmark functionality with custom deserializers in the serde benchmark crate.
- Updates documentation examples for map-like type deserialization and corrects several typos in the docs.
- Revises the README port list and fixes textual errors in CONTRIBUTING.md, doc/dom.md, and doc/iterate_many.md.
Reviewed Changes
Copilot reviewed 24 out of 36 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| doc/basics.md | Updates code examples for map-like types; note typo in namespace usage. |
| benchmark/static_reflect/serde-benchmark/lib.rs | Introduces CitmCatalog benchmark code and custom deserializers. |
| README.md | Revises port list with duplicate entries added. |
| CONTRIBUTING.md | Fixes typos in discussion guidelines. |
| doc/dom.md | Corrects spelling of "directive". |
| doc/iterate_many.md | Fixes typo in "data structure". |
Files not reviewed (12)
- benchmark/static_reflect/CMakeLists.txt: Language not supported
- benchmark/static_reflect/citm_catalog_benchmark/CMakeLists.txt: Language not supported
- benchmark/static_reflect/citm_catalog_benchmark/benchmark_serialization_citm_catalog.cpp: Language not supported
- benchmark/static_reflect/citm_catalog_benchmark/citm_catalog_data.h: Language not supported
- benchmark/static_reflect/citm_catalog_benchmark/nlohmann_citm_catalog_data.h: Language not supported
- benchmark/static_reflect/serde-benchmark/serde_benchmark.h: Language not supported
- benchmark/static_reflect/twitter_benchmark/CMakeLists.txt: Language not supported
- benchmark/static_reflect/twitter_benchmark/benchmark_serialization_twitter.cpp: Language not supported
- benchmark/static_reflect/twitter_benchmark/nlohmann_twitter_data.h: Language not supported
- include/simdjson/concepts.h: Language not supported
- include/simdjson/dom/document.h: Language not supported
- include/simdjson/dom/parser.h: Language not supported
Comments suppressed due to low confidence (1)
README.md:178
- Duplicate entry detected for the Zig port 'simdjzon'; consider removing one to avoid confusion.
- [simdjzon](https://github.com/travisstaloch/simdjzon): Zig port.
Haven't been able to validate this locally for now, as the reflection branch that I am building clang from doesn't have the new ^^ operator.
lemire
reviewed
Mar 26, 2025
| } | ||
|
|
||
| template <concepts::string_view_keyed_map T> | ||
| constexpr void atom(string_builder &b, const T &m) { |
lemire
reviewed
Mar 26, 2025
| ondemand::document doc = parser.iterate(json); | ||
| std:map<std::string,Car> cars; | ||
| error = doc.get<std:map<std::string,Car>>().get(cars); | ||
| std::map<std::string,Car> cars; |
lemire
reviewed
Mar 26, 2025
| #include "twitter_data.h" | ||
| #include "nlohmann_twitter_data.h" | ||
| #include "benchmark_helper.h" | ||
| #include "../benchmark_utils/benchmark_helper.h" |
Member
There was a problem hiding this comment.
This is fine but we may want to simplify this in a future PR by adding an extra path?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.