Adding DOM support for json path with wildcard#2346
Merged
lemire merged 62 commits intosimdjson:masterfrom Aug 14, 2025
Merged
Conversation
Member
|
@dabigjoe6 This is potentially useful work. |
Contributor
Author
Thanks for the feedback. I actually moved this to my fork to polish it up a bit more. I'll sync here and reach out here when it's ready for a proper look |
… order to prevent stack overflow
Member
|
@dabigjoe6 Please consider the following PR on top of your PR: dabigjoe6#4 |
some minor fixes
Member
|
Running tests. |
lemire
approved these changes
Aug 8, 2025
Member
|
Merged. Great work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation for #2306
Introduces wildcard support (*) for JSONPath queries, allowing bulk retrieval of array/object values through patterns like
$[*]or$.key.*.at_path_with_wildcard()toarray,object, andelementto avoid breaking changes as it usesstd::vector<element>return type which differs fromat_path()return type (open to suggestions if there's a way to make this work with existingat_pathfunction)get_values()function inarrayandobjectto return all child elements asstd::vector<element>$.*,$[*])$.address.*,$.*.streetAddress)Hi maintainers - this is my first C++ contribution, and I'm eager to learn. Please let me know if any patterns could be optimized or simplified 🙏