Conversation
cleaning msgpack_benchmarks.
|
@jkeiser @NicolasJiaxin Really fast JSON to msgpack transcoding. |
|
Nice! Will you also be adding tests? |
The benchmarks always include 'some testing' and here we test that all library implementation output the same size. Initially, I wanted all my implementation to have the exact same output (byte-by-byte) but that's tricky because of key ordering (there is no unique way to serialize an object if you are allowed to reorder the keys). However, the result is not well tested... for that, we would need an independent piece of code that can at least validate that we are producing 'valid msgpack'. If you'd like to contribute that, it would be great. There is probably readily available code to validate a msgpack payload. Another fun project would be to try to write fast code to 'compact' the msgpack output. |
Should be self-explanatory: adding benchmarks where we transcode from json to msgpack.