[bad design] This should improve string performance in ondemand by making the string processing runtime dispatched.#1847
Closed
[bad design] This should improve string performance in ondemand by making the string processing runtime dispatched.#1847
Conversation
…ng processing runtime dispatched.
Member
Author
|
I think I did it wrong. Having it as a separate dispatched function probably carries too much overhead. Let us investigate. |
Member
Author
|
Closing without a merge, since this was the wrong design. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current on-demand front-end, will, by default, use a slow parse_string that does not benefit from the processor's best instructions. We can make it available from the runtime dispatched kernels instead and possibly gain quite a bit of performance in some cases.
This should not affect people who compile simdjson for their processor.
On icelake (AWS, GCC 11), I get...
Before... (two runs)
After...
So we go from 4.8 GB/s to 5.6 GB/s, a 15% performance boost.