Skip to content

Clean up - Remove obsolete, duplicate and unused code #113

@silverhack

Description

@silverhack

Is your feature request related to a problem? Please describe.
Modules within Monkey365 were designed to work independently from each other and currently some internal modules have the same logic code to perform tasks. The following are some examples of duplicate code:

https://github.com/silverhack/monkey365/blob/main/core/modules/monkeyhtml/private/utils/Update-PsObject.ps1
https://github.com/silverhack/monkey365/blob/main/core/modules/monkeyutils/public/Update-PsObject.ps1
https://github.com/silverhack/monkey365/blob/main/core/modules/monkeyjob/private/Get-CommandInfo.ps1
https://github.com/silverhack/monkey365/blob/main/core/modules/monkeyast/public/Get-CommandInfo.ps1

Additionally, PSScriptAnalyzer generate some warnings that should be addressed in order to publish the module to PowerShell Gallery #112.

Describe the solution you'd like
Add new helpers functions so each module can call the helper functions with parameters instead. Additionally, consider to remove some packages and internal funcions that are not used anymore.

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions