Skip to content

Conversation

@josephmyers
Copy link
Collaborator

@josephmyers josephmyers commented Jun 7, 2024

Updating Palaso dependencies fixes #5

This is pretty rough. There is likely a good bit more cleanup we can do
@josephmyers
Copy link
Collaborator Author

josephmyers commented Jun 7, 2024

I am still working on getting the tests running on my machine

Update: I forgot that, for Framework 4.6.1, dotnet test can't find the test assemblies automatically. You have to do:
dotnet test ../output/net461/*Tests.dll

@josephmyers josephmyers requested a review from megahirt June 7, 2024 09:00
Tests can be run with `dotnet test  ../output/net461/*Tests.dll`
@josephmyers josephmyers linked an issue Jun 13, 2024 that may be closed by this pull request
@josephmyers
Copy link
Collaborator Author

@megahirt, this fixes the issue Beth is seeing

Copy link
Contributor

@megahirt megahirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Yes sir!

@josephmyers josephmyers merged commit 7f07bb5 into main Jun 13, 2024
@megahirt megahirt deleted the update-dependencies branch June 14, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash when WritingSystemStore has any .ldml files in it

3 participants