Skip to content

Update launch.json .NET folder 3.1 -> 5.0.#1245

Merged
imnasnainaec merged 1 commit intomasterfrom
launch-json-net5
Jul 8, 2021
Merged

Update launch.json .NET folder 3.1 -> 5.0.#1245
imnasnainaec merged 1 commit intomasterfrom
launch-json-net5

Conversation

@imnasnainaec
Copy link
Copy Markdown
Collaborator

@imnasnainaec imnasnainaec commented Jul 8, 2021

Like #391, but for debugging after the switch to .NET 5.0 (#1198).


This change is Reviewable

@imnasnainaec imnasnainaec added the maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. label Jul 8, 2021
@imnasnainaec imnasnainaec self-assigned this Jul 8, 2021
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 8, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.23%. Comparing base (e4716cf) to head (3b6bcc3).
⚠️ Report is 1128 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1245      +/-   ##
==========================================
- Coverage   45.36%   45.23%   -0.13%     
==========================================
  Files         266      266              
  Lines        8137     8137              
  Branches      531      531              
==========================================
- Hits         3691     3681      -10     
- Misses       4027     4037      +10     
  Partials      419      419              
Flag Coverage Δ
backend 58.37% <ø> (-0.26%) ⬇️
frontend 33.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@WeJamUS WeJamUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit f755f79 into master Jul 8, 2021
@imnasnainaec imnasnainaec deleted the launch-json-net5 branch July 8, 2021 21:35
@johnthagen
Copy link
Copy Markdown
Contributor

@imnasnainaec Sorry I missed this one. Since I wasn't using VSCode, I didn't realize this was needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants