Fix: fallback text needed to avoid breaking the browser#518
Conversation
robofish
left a comment
There was a problem hiding this comment.
lgtm
indentation of the file appears to be inconsistent however.
|
Hi! 👋 Just checking in to see if there's an estimated timeline for merging this PR. We've tested the fix and it's working well on our end — would love to rely on the official package once it's merged. Thanks! |
|
apparently the old behavior (e.g. using reactgrid@4.1.12) allows copying again in Chrome v135. So maybe the chrome engineers have reversed some changes. haven't seen anything about it on the high-level changelog though. |
|
We are currently using version |
This pull request includes changes to the
src/lib/Functions/handleCopy.tsfile to improve the clipboard copy functionality and handle errors more gracefully. The most important changes include reordering imports for consistency and enhancing thecopyDataCommandsfunction to support plain text and handle errors.Improvements to clipboard copy functionality:
src/lib/Functions/handleCopy.ts: Reordered the import ofgetDataToCopyfor consistency.src/lib/Functions/handleCopy.ts: Enhanced thecopyDataCommandsfunction to include support for plain text and added error handling for clipboard operations.There's more info about why using only html is broken here: https://github.com/nikouu/Web-API-Clipboard.write-Examples?ref=nikouusitalo.com
I tested this in ubuntu using chrome, firefox and brave with cells grid of number, text and custom select.
This should fix #509