Skip to content

use navigator clipboard if has support #510#514

Merged
MichaelMatejko merged 2 commits into
silevis:developfrom
Luisgustavom1:fix/copy-paste-on-chrome-134
Mar 25, 2025
Merged

use navigator clipboard if has support #510#514
MichaelMatejko merged 2 commits into
silevis:developfrom
Luisgustavom1:fix/copy-paste-on-chrome-134

Conversation

@Luisgustavom1

@Luisgustavom1 Luisgustavom1 commented Mar 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR is to fix this issues on chrome 134.*

Recent updates on chrome (134.* > ) broken the .execCommand in some cases, as reported in some issues like this one https://issues.chromium.org/issues/401379144

#509
#507

@Luisgustavom1 Luisgustavom1 force-pushed the fix/copy-paste-on-chrome-134 branch from 5c1eff6 to f4c7854 Compare March 14, 2025 11:08
@Luisgustavom1 Luisgustavom1 mentioned this pull request Mar 14, 2025
Merged
Luisgustavom1
Luisgustavom1 commented Mar 14, 2025
View reviewed changes
Comment thread src/lib/Functions/handleCopy.ts
};
const clipboardItem = new ClipboardItem(clipboardItemData);
await navigator.clipboard.write([clipboardItem]);
navigator.clipboard.write([clipboardItem]).then(() => ({}));

@Luisgustavom1 Luisgustavom1 Mar 14, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the best way to handle promises on Behavior class?

To not change architecture and turn this method a promise, I only handle promise of clipboard.write with .then

What's the project pattern to handle errors? We let the error pop up for the user to handle? We take it and treat it directly at the lib?

@salah-khan-g3

salah-khan-g3 commented Mar 14, 2025

Copy link
Copy Markdown

If anyone can give us a ETA, that would be nice.

@Luisgustavom1

Luisgustavom1 commented Mar 15, 2025

Copy link
Copy Markdown
Contributor Author

If anyone can give us a ETA, that would be nice.

for sure

@dilyan-atanasov

dilyan-atanasov commented Mar 17, 2025

Copy link
Copy Markdown

When will this be applied so that we can remove our temporary solutions?

@arasovic

arasovic commented Mar 17, 2025

Copy link
Copy Markdown

hello @webloopbox
do you have a timeline for the next version or patch? like v4.1.16 or something
could you provide any information about it?

@webloopbox

webloopbox commented Mar 19, 2025

Copy link
Copy Markdown
Contributor

We'll release version 4.1.16, which includes a fix for this issue, at the beginning of next week

@Luisgustavom1

Luisgustavom1 commented Mar 23, 2025

Copy link
Copy Markdown
Contributor Author

We'll release version 4.1.16, which includes a fix for this issue, at the beginning of next week

great news

@MichaelMatejko MichaelMatejko merged commit eeef7ba into silevis:develop Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaelMatejko MichaelMatejko MichaelMatejko approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Luisgustavom1 @salah-khan-g3 @dilyan-atanasov @arasovic @webloopbox @MichaelMatejko