Skip to content

Restrict permissions when compressing#53

Merged
sile merged 1 commit intosile:masterfrom
macladson:compress-perms-fix
Nov 15, 2021
Merged

Restrict permissions when compressing#53
sile merged 1 commit intosile:masterfrom
macladson:compress-perms-fix

Conversation

@macladson
Copy link
Contributor

This should resolve #52.
This restricts the compressed file permissions before anything is written into the file.

@coveralls
Copy link

coveralls commented Nov 8, 2021

Pull Request Test Coverage Report for Build 1432735431

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 8 of 9 (88.89%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 48.381%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/file.rs 8 9 88.89%
Files with Coverage Reduction New Missed Lines %
../../../../../usr/share/rust/.cargo/registry/src/github.com-1ecc6299db9ec823/crossbeam-channel-0.5.1/src/context.rs 1 57.38%
Totals Coverage Status
Change from base Build 1415142534: 0.2%
Covered Lines: 1599
Relevant Lines: 3305

💛 - Coveralls

@sile
Copy link
Owner

sile commented Nov 9, 2021

Thanks!
I'll review this PR this weekend.

Copy link
Owner

@sile sile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@sile sile merged commit 5a8ee0c into sile:master Nov 15, 2021
@macladson macladson deleted the compress-perms-fix branch November 15, 2021 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logfile compression bypasses restricted permissions

3 participants