Add mame crate dependency and migrate from unicode-width#9
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the codebase from the unicode-width crate to the mame crate for handling terminal character width calculations. The change replaces Unicode width estimation functionality across multiple files.
- Removes dependency on
unicode-widthcrate and addsmamecrate - Replaces
UnicodeWidthStrandUnicodeWidthChartrait usages withmame::terminalfunctions - Updates custom
UnicodeCharWidthEstimatorimplementation to usemame::terminal::UnicodeTerminalFrame
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Updates dependencies: removes unicode-width, adds mame 0.1.4 |
| src/canvas.rs | Removes custom char width estimator, replaces with mame terminal frame and functions |
| src/git.rs | Replaces UnicodeWidthStr usage with mame::terminal::str_cols function |
| src/widget_command_editor.rs | Migrates string width calculation to mame::terminal::str_cols |
| src/widget_search_result.rs | Updates string width calculations to use mame::terminal functions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.