Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new flag to hide the legend by default, allowing users to disable the legend through a command line flag or an environment variable.
- Introduces the "hide-legend" flag in the argument parsing section in src/main.rs
- Passes the new flag to the App constructor in src/app.rs to configure the LegendWidget
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main.rs | Adds a flag to hide the legend and updates the App call |
| src/app.rs | Updates the App::new constructor to accept the hide_legend flag and configures the LegendWidget accordingly |
Comments suppressed due to low confidence (1)
src/main.rs:48
- Consider adding tests to verify that the 'hide-legend' flag correctly toggles the legend display, including behavior with the environment variable override.
let hide_legend = noargs::flag("hide-legend")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.