Add external command execution support with environment variables#11
Merged
Add external command execution support with environment variables#11
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds external command execution support to the application with environment variables for current cursor context. It introduces a preview system to display command output and simplifies action applicability logic.
- Add external command execution with preview display for stdout/stderr
- Provide environment variables (MAMEGREP_FILE, MAMEGREP_LINE, MAMEGREP_GREP_COMMAND) to external commands
- Remove deprecated FlipCaseSensitive action and simplify context boundary checks
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/app.rs | Adds preview field, command execution logic, and environment variable setup |
| src/action.rs | Removes FlipCaseSensitive action and adds ExecuteCommand variant |
| configs/sile.jsonc | New SILE configuration with comprehensive key bindings including external commands |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.