Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the application from direct key handling to an action-based event system with JSON configuration support. It integrates the mame framework's action binding system to provide configurable keybindings and improves code modularity.
Key changes:
- Add JSON configuration support with default config and CLI option for custom config files
- Replace direct key input handling with an action-based system using the mame framework
- Refactor widgets to handle actions instead of raw key inputs and remove dirty state tracking
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/action.rs | New action enum with JSON deserialization and state-dependent filtering |
| src/app.rs | Core refactor to use binding system, remove dirty tracking, add config support |
| src/main.rs | Add config file CLI option and load default/custom configurations |
| src/widget_*.rs | Convert widgets from key input to action handling |
| src/canvas.rs | Remove unused col_offset functionality |
| src/git.rs | Increase max context lines from 9 to 20 |
| configs/default.jsonc | New default configuration with comprehensive keybindings |
| Cargo.toml | Update mame dependency and add nojson for JSON parsing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.