Skip to content

Add vim movement keys#1

Merged
sile merged 1 commit intosile:mainfrom
blackdaemon:main
Feb 26, 2025
Merged

Add vim movement keys#1
sile merged 1 commit intosile:mainfrom
blackdaemon:main

Conversation

@blackdaemon
Copy link
Copy Markdown
Contributor

Add vim movement keys h, j, k, l
'h' to toggle legend changed to 'H'

Add vim movement keys h, j, k, l
'h' to toggle legend changed to 'H'
Copy link
Copy Markdown
Owner

@sile sile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hank you for your PR. LGTM!

I have a few minor tweaks, such as changes to the legend format. However, since they are trivial, I will apply them after merging.

@sile sile merged commit ed21656 into sile:main Feb 26, 2025
@sile
Copy link
Copy Markdown
Owner

sile commented Feb 26, 2025

[FYI] I will release the next version this weekend.

@blackdaemon
Copy link
Copy Markdown
Contributor Author

I saw your commits, you were really busy! Very cool tool you made, I love it. It just needs some coloring ;-)

@sile
Copy link
Copy Markdown
Owner

sile commented Feb 27, 2025

Very cool tool you made, I love it.

Thanks!

It just needs some coloring ;-)

Coloring is certainly an appealing feature.
However, since I have been recently developing on a black-and-white e-ink device (where coloring can reduce visibility), I am not strongly motivated to implement it.
I'm unsure if I can merge such a feature, but if you have any concrete ideas for adding color to the UI, a pull request is welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants