Fix an error when staging the deletion of binary files#6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot Summary
This pull request includes changes to the way binary file diffs are handled in the
src/diff.rsandsrc/git.rsfiles. The updates aim to improve the accuracy and reliability of generating binary file diffs by modifying the method calls and parameters.Changes to binary file diff handling:
src/diff.rs: Updated theFileDiffimplementation to use thebinary_file_diffmethod instead ofnew_file_difffor binary content diffs.src/git.rs: Modified thebinary_file_difffunction to include an additional--parameter in thediffcommand to ensure proper handling of file paths and to differentiate between staged and unstaged changes.