Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds visual feedback for ongoing key bindings in the legend widget through highlighting, along with API refactoring to use the new mame BindingConfig system.
- Adds
highlight_active_bindingoption to enable/disable visual highlighting of active bindings - Migrates from ActionBindingSystem to the newer BindingConfig API from mame 0.2.3
- Refactors legend widget fields to be public and removes the init method
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/widget_legend.rs | Adds highlighting logic for active bindings and changes API to accept binding arrays |
| src/main.rs | Updates to use BindingConfig instead of ActionBindingSystem |
| src/app.rs | Implements binding tracking and highlighting behavior with new API |
| src/action.rs | Adds highlight_active_binding field to InitLegend action |
| configs/sile.jsonc | Enables highlighting in configuration |
| Cargo.toml | Updates mame and nojson dependencies |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.