Update key bindings system and bump mame dependency to 0.2.0#25
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the key bindings system by migrating from Config to ActionBindingSystem and bumps the mame dependency from version 0.1.5 to 0.2.0.
- Replaces
ConfigwithActionBindingSystemacross all components - Updates configuration file format to use "bindings" instead of "keybindings" and "triggers" instead of "keys"
- Updates mame dependency to version 0.2.0
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/widget_legend.rs | Updates import and parameter type from Config to ActionBindingSystem, changes method calls to match new API |
| src/main.rs | Replaces Config with ActionBindingSystem in imports and variable declarations, updates help text |
| src/app.rs | Changes struct field and parameter types from Config to ActionBindingSystem |
| src/action.rs | Updates type alias from ActionConfig to ActionBindingSystem |
| configs/sile.jsonc | Renames "keybindings" to "bindings" and "keys" to "triggers" throughout configuration |
| configs/default.jsonc | Renames "keybindings" to "bindings" and "keys" to "triggers" throughout configuration |
| Cargo.toml | Bumps mame dependency version from 0.1.5 to 0.2.0 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.