Update dependencies and migrate from execute-shell to execute-command#24
Merged
Update dependencies and migrate from execute-shell to execute-command#24
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the mame dependency from 0.1.4 to 0.1.5 and migrates from the deprecated execute-shell action to the newer execute-command action pattern.
Key changes:
- Simplified generic type inference in legend widget rendering
- Migrated shell command configurations from
execute-shelltoexecute-command - Added spacing to legend labels for improved formatting
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/widget_legend.rs |
Simplified type inference and added label spacing |
src/app.rs |
Removed deprecated ExecuteShell action handling |
src/action.rs |
Removed ExecuteShell enum variant and related code |
configs/sile.jsonc |
Migrated shell commands to execute-command format |
Cargo.toml |
Updated mame dependency to version 0.1.5 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.