Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds command execution support to the application, enabling users to run external commands and shell scripts through configured keybindings. The implementation displays command output in a preview pane with stdout and stderr results.
- Added
ExecuteCommandandExecuteShellaction types for handling external command execution - Integrated a preview widget to display command execution status and output
- Updated dependency version to support the new command functionality
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/app.rs | Added preview widget field and command execution logic with output display |
| src/action.rs | Added new action variants for command and shell execution |
| configs/sile.jsonc | Added keybinding configurations for commit and push operations |
| Cargo.toml | Updated mame dependency to version 0.1.3 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.