Conversation
… input handling to use action-based system
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive JSON configuration support to the application, replacing hardcoded key bindings and actions with a flexible configuration system. The changes introduce an action-based input handling system with customizable keybindings and dynamic legend generation.
- Add JSON configuration system with Action enum and Config type alias for managing keybindings and actions
- Refactor input handling from hardcoded key patterns to action-based system using configuration files
- Replace command-line hide-legend option with JSON-configurable legend settings and dynamic legend generation
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/action.rs | New module defining Action enum with JSON parsing and applicability checking for DiffTreeWidget |
| src/main.rs | Replace hide-legend CLI flag with config file loading and add nojson dependency |
| src/app.rs | Refactor from key-based to action-based input handling using configuration |
| src/widget_legend.rs | Update legend rendering to use dynamic keybinding labels from configuration |
| src/lib.rs | Add action module declaration |
| configs/default.jsonc | Default JSON configuration with keybindings and legend settings |
| Cargo.toml | Add nojson dependency for JSON parsing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.