Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors terminal rendering to use the mame crate instead of the unicode-width dependency for terminal width calculations. The changes simplify the legend rendering logic and improve the terminal frame handling.
- Replace unicode-width dependency with mame 0.1.1 for character width calculations
- Refactor legend rendering to use mame's built-in legend functionality
- Update terminal frame creation to use mame's UnicodeTerminalFrame
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Cargo.toml | Add mame 0.1.1 dependency and remove unicode-width |
| src/canvas.rs | Replace unicode-width functions with mame equivalents and update frame creation |
| src/widget_legend.rs | Refactor legend rendering to use mame's Legend struct instead of manual canvas drawing |
| src/app.rs | Update rendering flow to separate canvas and frame operations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.