Conversation
… styling management
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the crossterm dependency and refactors terminal handling to use the tuinix library. Key changes include:
- Replacing crossterm types and functions with their tuinix counterparts in various modules.
- Refactoring canvas rendering to produce a TerminalFrame using a UnicodeCharWidthEstimator.
- Updating event handling in App to use tuinix’s TerminalEvent and TerminalInput APIs.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/widget_legend.rs | Replaced TokenPosition with TerminalPosition for cursor handling. |
| src/widget_diff_tree.rs | Updated token styling to use TerminalStyle instead of TokenStyle. |
| src/terminal.rs | Removed terminal handling implementation using crossterm. |
| src/lib.rs | Removed terminal module import. |
| src/canvas.rs | Refactored drawing methods to use TerminalPosition and a TerminalFrame. |
| src/app.rs | Updated event handling to utilize tuinix TerminalEvent/Input types. |
| Cargo.toml | Removed crossterm dependency and added the tuinix dependency. |
| .cargo/config.toml | Added a simple cargo alias for development. |
crossterm dependency with tuinix for terminal handling
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.