Fix "\ No newline at end of file" line handling#10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot Summary
This pull request includes changes to the
src/diff.rsfile to handle the case of "No newline at end of file" in diffs. The most important changes include adding a new variant to theLineDiffenum, updating theChunkDiffstruct and its methods to remove theno_eof_newlinefield, and modifying theDisplayimplementations accordingly.Enhancements to
LineDiffenum:NoNewlineAtEndOfFilevariant to theLineDiffenum.FromStrimplementation forLineDiffto handle the new variant.Displayimplementation forLineDiffto properly display the new variant.Modifications to
ChunkDiffstruct:no_eof_newlinefield from theChunkDiffstruct.ChunkDiffmethods to remove handling of theno_eof_newlinefield. [1] [2]Displayimplementation forChunkDiffto remove the display logic for theno_eof_newlinefield.Additional updates:
DiffTreeNodeContentimplementation forLineDiffto include the new variant.