Include placementConstraints when regenerating task definition#114
Merged
fillup merged 1 commit intosil-org:developfrom Dec 18, 2017
Merged
Include placementConstraints when regenerating task definition#114fillup merged 1 commit intosil-org:developfrom
fillup merged 1 commit intosil-org:developfrom
Conversation
fillup
approved these changes
Dec 18, 2017
|
But if you don't specify any placement constraints in task definition? I think this PR commit makes our CI failed with this error: Master branch works fine. Please review this again before merge it to master. |
|
Bump? |
Contributor
Author
|
@manhtai you're saying if you don't specify placementConstraints in your taskDefinition, you get that error, but otherwise works? In checking the ECS docs, it looks like this property is still a thing. |
|
Problem seems to be an old version of awscli. Not sure which version you need though. Latest version works. |
|
@Wyntuition Yep |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you have specified placement constraints in your task definition (i.e. only deploy these to this instance), they won't get included when the task generation gets regenerated, for a new deployment. This includes them.