Don't mark hash argument as required.#644
Merged
Hayden-IO merged 1 commit intosigstore:mainfrom Feb 22, 2024
Merged
Conversation
The hash hash argument a default value, which is documented. The mark required call broke this as it forces the caller to actually provide the hash algorithm Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #644 +/- ##
==========================================
+ Coverage 52.85% 54.85% +1.99%
==========================================
Files 20 20
Lines 1209 948 -261
==========================================
- Hits 639 520 -119
+ Misses 509 367 -142
Partials 61 61 ☔ View full report in Codecov by Sentry. |
cpanato
approved these changes
Feb 22, 2024
Hayden-IO
approved these changes
Feb 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The hash hash argument a default value, which is documented. The mark required call broke this as it forces the caller to actually provide the hash algorithm
Release Note
--hashargument to thetimestamp-cli timestampcommand is now optional as the documentation explainsDocumentation
n/a