Upgrade chi middleware v4 -> v5#1307
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1307 +/- ##
===========================================
- Coverage 52.85% 17.12% -35.74%
===========================================
Files 20 55 +35
Lines 1209 3072 +1863
===========================================
- Hits 639 526 -113
- Misses 509 2493 +1984
+ Partials 61 53 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hayden-IO
reviewed
Mar 3, 2026
* chi has beens seen panicing with "slice bounds out of range [-1:]" while recovering a panic * Upgrade is expected to fix things as the panicing function has been rewritten Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Hayden-IO
approved these changes
Mar 3, 2026
Hayden-IO
left a comment
Contributor
There was a problem hiding this comment.
Thank you for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that I don't know anything about chi or the versions here, apart from v5 being the maintained version. Tests seem to pass
Fixes #1306 (maybe)