verify: Refactor log entry consistency verification#103
Merged
Conversation
Verify that 1. We understand each entry (kind and version) 2. The entry matches the bundle material The old code seemingly only verified the second part if we happened to recognise the entry type. Additionally, only runs this code if policy includes "verify_tlog". Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Member
Author
|
I'm not really 100% sure about this design but it seems like an improvement:
|
wolfv
approved these changes
May 28, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verify that
The old code seemingly only verified the second part if we happened to recognise the entry type (unknown types and versions were just skipped)
Additionally, only runs this code if policy includes "verify_tlog".