Include OIDC in signing config, use TUF in examples#102
Merged
Conversation
jku
commented
May 27, 2026
Member
- Include OIDC URL in SigningConfig -- This makes e.g. signing examples work with "--staging" while interactive.
- Support URL argument in get_identity_token() -- This way the oidc usage remains simple even with dynamic URL
- Support "--staging" in the verify example -- this is just a QOL improvement for testing things with the example, not really required
- Examples: Use TUF throughout -- This feels appropriate to me: let's mainly show the usage that is most likely to be correct for most users
This makes e.g. signing examples work with --staging. Examples have been modified so the oidc token request happens after TUF config. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
This way the OIDC URL is not hard coded Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
I think this is appropriate: We should mainly show the likely "correct" way to use the library. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
6b8f370 to
285522b
Compare
wolfv
approved these changes
May 28, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.