tests: Try to not fail negative key tests if support is not there#1605
Merged
Conversation
We want to test the _get_key_details() with some unexpected cryptographic material, but we don't want the test suite to fail while collecting tests if cryptography itself does not support these keys (since we're only testing failure cases here). Delay the key generation code with a lambda so we can handle cryptography exception and skip the test in these negative tests. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
eed1143 to
49ff3d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to test the _get_key_details() with some unexpected cryptographic material, but we don't want the test suite to fail while collecting tests if cryptography itself does not support these keys (since we're only testing failure cases here).
Delay the key generation code with a lambda so we can handle cryptography exception and skip the test in these negative tests.
I decided to jump through the hoops of skipping instead of just removing the problematic SECT163 curve -- we don't care about SECT163 as such but I figured it's good to test at least one "unsupported ec curve"
fixes #1603