rekor: Fix checkpoint signature lookup#1514
Merged
Merged
Conversation
6a43f2c to
b40c51f
Compare
Checkpoint can have multiple signatures from multiple keys. We just want one of them to be the log key. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
b40c51f to
cdfdaab
Compare
Member
Author
|
@haydentherapper can you confirm this is what we want here: the log must have a signature in the checkpoint, otherwise we don't care about the signatures at this point. |
Member
Author
|
I'll merge as is. I was debating myself whether I need to add more tests for checkpoint... but conformance tests for this, that should be good enough |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checkpoint can have multiple signatures from multiple keys. We just want one of them to be the log key.
This looks like it will fix #1513