tests: Fix issues from recent staging signingconfig change#1484
Merged
Conversation
The modified tests fail for staging since staging now has a rekorv2 instance in the staging signingconfig (and RekorV2Client does not have log lookup functionality). * Stop running test_sign_rekor_entry_consistent() with staging: We could do the log lookup in the test but I'm not sure it's worth the trouble * Avoid doing the log lookup in test_identity_proof_claim_lookup: It does not seem relevant to the test I also renamed the second test and rewrote the comment as I did not quite understand what it was going for. Fixes sigstore#1483 Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
woodruffw
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The modified tests fail for staging since staging now has a rekorv2 instance in signingconfig leading the client to use RekorV2Client (and RekorV2Client does not have log lookup functionality that the tests try to use).
I also renamed the second test and rewrote the comment as I did not quite understand what it was going for.
Fixes #1483