Conformance client update#1443
Merged
Merged
Conversation
woodruffw
reviewed
Jun 12, 2025
This contains working staging support Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
c1f4419 to
add5ac4
Compare
conformance clients are given "--trusted-root" but sigstore-python requires "--trust-config". Build a trust config and provide that in the conformance client script. The conformance scipt is getting closer and closer to the point where just tweaking argv is not really the smart thing to do... but it's still manageable. This revealed a new bug so one test remains "xfail". Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
woodruffw
approved these changes
Jun 13, 2025
Member
|
Thanks @jku! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #821 by adding support for
--trusted-rootinto our conformance client.Annoyingly this requires writing a temporary (trust config) file on disk since that is what sigstore-python CLI needs instead of the provided trustedroot file.
This revealed a new issue #1442