Client support for Rekor V2: sigstore-python #289
Description
The inclusion_promise is meant to be optional in the TransparencyLogEntry, but the _to_rekor() method would explicitly set TransparencyLogEntry.inclusion_promise to None upon instantiation. Pydantic won't allow this.
File "/usr/local/google/home/rpetgrave/src/ssp/sigstore-python/sigstore/models.py", line 262, in _to_rekor
tlog_entry = rekor_v1.TransparencyLogEntry(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/google/home/rpetgrave/src/ssp/.venv/lib/python3.12/site-packages/pydantic/_internal/_dataclasses.py", line 120, in __init__
s.__pydantic_validator__.validate_python(ArgsKwargs(args, kwargs), self_instance=s)
pydantic_core._pydantic_core.ValidationError: 1 validation error for TransparencyLogEntry
inclusion_promise
Input should be a dictionary or an instance of InclusionPromise [type=dataclass_type, input_value=None, input_type=NoneType]
Version
main @6937b05c3379fb6a3b23e47597a26e2cc72ababe
Client support for Rekor V2: sigstore-python #289
Description
The
inclusion_promiseis meant to be optional in theTransparencyLogEntry, but the_to_rekor()method would explicitly setTransparencyLogEntry.inclusion_promisetoNoneupon instantiation. Pydantic won't allow this.Version
main @6937b05c3379fb6a3b23e47597a26e2cc72ababe