test/assets: remove rekor v2 dsse/0.0.2 bundle-verify fixtures#374
Merged
Conversation
The rekor2-dsse-* fixtures embed a Rekor TLog entry with kind=dsse/0.0.2. Upcoming sigstore-go and sigstore-python releases drop verifier support for the dsse entry type in favor of representing DSSE envelopes as hashedrekord (see architecture-docs PR sigstore#63, rekor-v2-spec section 6.1.4). Removing these fixtures here lets a new conformance release ship ahead of the client changes so client CI stays green. Replacement hashedrekord-DSSE fixtures will land in a follow-up PR. Removed: - test/assets/bundle-verify/rekor2-dsse-happy-path - test/assets/bundle-verify/rekor2-dsse-invalid-sig_fail - test/assets/bundle-verify/rekor2-dsse-mismatch-envelope_fail - test/assets/bundle-verify/rekor2-dsse-mismatch-sig_fail Signed-off-by: Cody Soyland <cody.soyland@chainguard.dev>
loosebazooka
approved these changes
May 19, 2026
loosebazooka
left a comment
Member
There was a problem hiding this comment.
Yeah I think this is a fine transition, but it may not be too much to ask clients to just add xfails and figure it out. Either way, lets get this moving. I'm fine with this approach.
Member
|
Oh do you need one of us to merge? |
Member
|
@jku no concerns? I'll merge it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the four
rekor2-dsse-*bundle-verify fixtures, whose Rekor TLog entries usekind=dsse/0.0.2.Upcoming client releases drop verifier support for the
dsseRekor entry type in favor of representing DSSE envelopes ashashedrekord(see architecture-docs PR #63,rekor-v2-spec§6.1.4). Those client PRs are currently blocked by these fixtures — e.g. sigstore-python#1776 fails withUnsupported DSSE log entry type: dsse/0.0.2ontest_verify[*-rekor2-dsse-happy-path].Removing these fixtures here lets a new conformance release ship ahead of the client changes so client CI stays green. Replacement
hashedrekord-DSSE fixtures will land in #371.The four pre-existing
kind=dsse/0.0.1fixtures (dsse-*_fail,happy-path-intoto-in-dsse-v3) are intentionally left in place; they can be retired separately if/when clients drop0.0.1support too.Removed
test/assets/bundle-verify/rekor2-dsse-happy-pathtest/assets/bundle-verify/rekor2-dsse-invalid-sig_failtest/assets/bundle-verify/rekor2-dsse-mismatch-envelope_failtest/assets/bundle-verify/rekor2-dsse-mismatch-sig_fail