Basic rekorv2 tests#216
Merged
Merged
Conversation
This was referenced Jun 13, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Member
Author
|
I've added a few tests more but don't plan on adding anything to this PR -- will start new PRs for next tests to keep the number per PR reasonable |
Member
Author
|
The size of the PR could be cut in half by having some smarter way of using the custom/staging trusted root as |
loosebazooka
approved these changes
Jul 15, 2025
loosebazooka
left a comment
Member
There was a problem hiding this comment.
@aaronlew02 do we have any other test-cases that might be interesting to add (in a followup pr)?
Member
|
@aaronlew02 also I think we can test these against sigstore-java tomorrow or later in the week once the PRs are in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add very basic tests for verifying rekorv2 bundles (happy path test and a few timestamp related tests).
Clients can set XFAIL as usual if they do not support rekorv2 yet (we don't have a SKIP input so they need to do XFAIL but maybe we should have it so clients could just skip all tests they don't support -- as an example
"*intoto*, *rekor2*") instead of having to XFAIL just the ones that have unexpected results